Improve electron security #428
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madman10K
added
enhancement
…HTML file, remove inline JS eval from main process, add additional security restrictions
Madman10K
force-pushed
the
improve-electron-security
branch
from
a5c84c6 to
98b9f81
Compare
Madman10K
force-pushed
the
improve-electron-security
branch
from
8cb492c to
ff2601e
Compare
… out of html files + small refactoring and reformatting
Madman10K
force-pushed
the
improve-electron-security
branch
from
ff2601e to
4bca2c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're violating many electron security guidelines right now. Sure, it's bad for security, but it also restricts us in terms of what electron dependencies we can use in some cases(previous issues with updating node dependencies from June/May(?)) and it also restricts us in terms of our future electron bundling.
Therefore, I'm making this PR. The goals of this PR are:
file://protocol